Fix TOML parse failure when number token hits buffer edge #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a number token is exactly at the end of the lexer text buffer, the parser would advance the lexer, triggering a buffer refill, before the number is parsed from the buffer. This patch moves the advance operation to come after parsing, which resolves the issue. Kudos to @wbprime for finding this and reporting it as micronaut-projects/micronaut-toml#93 . Not even the fuzzer managed to hit this – maybe because it does not fail fast, and just returns the wrong output (NumberInput does no input checking)?
|
hm outstanding test failures... |
yawkat
added a commit
to micronaut-projects/micronaut-toml
that referenced
this pull request
Nov 22, 2022
When a number token is exactly at the end of the lexer text buffer, the parser would advance the lexer, triggering a buffer refill, before the number is parsed from the buffer. This patch moves the advance operation to come after parsing, which resolves the issue. Also tracked as FasterXML/jackson-dataformats-text#356 Fixes #93
|
i think the fuzz tests just fail because of illegal tokens now, but as long as there's a failure, this seems fine |
|
@yawkat Correct, many/most methods in |
cowtowncoder
approved these changes
Nov 22, 2022
cowtowncoder
added a commit
that referenced
this pull request
Nov 22, 2022
yawkat
added a commit
to micronaut-projects/micronaut-toml
that referenced
this pull request
Nov 23, 2022
When a number token is exactly at the end of the lexer text buffer, the parser would advance the lexer, triggering a buffer refill, before the number is parsed from the buffer. This patch moves the advance operation to come after parsing, which resolves the issue. Also tracked as FasterXML/jackson-dataformats-text#356 Fixes #93 Co-authored-by: Tim Yates <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a number token is exactly at the end of the lexer text buffer, the parser would advance the lexer, triggering a buffer refill, before the number is parsed from the buffer. This patch moves the advance operation to come after parsing, which resolves the issue.
Kudos to @wbprime for finding this and reporting it as micronaut-projects/micronaut-toml#93 . Not even the fuzzer managed to hit this – maybe because it does not fail fast, and just returns the wrong output (NumberInput does no input checking)?